Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard identifiers for lights #1739

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

rytilahti
Copy link
Owner

Add standard identifiers for lights based on what is used by miotspec.
Also convert yeelight integration to use them.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #1739 (0dd97d0) into master (c8a3f4b) will decrease coverage by 0.02%.
The diff coverage is 71.87%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
- Coverage   81.92%   81.91%   -0.02%     
==========================================
  Files         196      196              
  Lines       18057    18077      +20     
  Branches     3864     3862       -2     
==========================================
+ Hits        14794    14807      +13     
- Misses       2973     2980       +7     
  Partials      290      290              
Impacted Files Coverage Δ
miio/integrations/yeelight/light/yeelight.py 78.14% <66.66%> (-1.46%) ⬇️
miio/identifiers.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit e0511d9 into master Feb 20, 2023
@rytilahti rytilahti deleted the feat/standard_light_identifiers branch February 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants